Skip to content

Add - to domain regex match#2

Closed
fprimex wants to merge 1 commit intoSendSafely:masterfrom
fprimex:fprimex-domain-regex
Closed

Add - to domain regex match#2
fprimex wants to merge 1 commit intoSendSafely:masterfrom
fprimex:fprimex-domain-regex

Conversation

@fprimex
Copy link
Copy Markdown

@fprimex fprimex commented Aug 22, 2018

Match domains that contain a -, such as my-domain.my-company.com.

Match domains that contain a `-`, such as `my-domain.my-company.com`.
@fprimex
Copy link
Copy Markdown
Author

fprimex commented Aug 27, 2018

While we're at it on parsing links, could this class be made public so it can be used without initializing a client API object? I have a use case where I'd like to see if there are any links before running initialsetup, since it appears that initialsetup makes a connection that can cause the rate limit to be hit.

So I would instead do repeated parselinks on text, and then connect if needed. Since I'm invoking this program many consecutive times via another program, I can't reuse the one API connection unless I rewrite the entire other program in C# (which would be cool, but I don't have the time right this minute).

SendSafely-GitHub added a commit that referenced this pull request Aug 31, 2018
Adds support for hyphinated host names in ParseLinksUtility
Exposes ParseLinksUtility as public

Original feature request/bug report can be found here: #2
@SendSafely-GitHub
Copy link
Copy Markdown
Collaborator

Hi Brent --

Thanks for reporting this issue to us. Our development team has just pushed an alternative fix we believe will address the issue you ran into with a hyphenated host name. We also changed the visibility on the ParseLinksUtility so it is now public and can be used without initializing the Client API object.

The commit with the fix can be found here: ca699ac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants